Skip to content

more fixes #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 11, 2022
Merged

more fixes #18

merged 5 commits into from
Apr 11, 2022

Conversation

mazgch
Copy link
Contributor

@mazgch mazgch commented Apr 10, 2022

Hi @PaulZC, @nseidle

  • be polite and yield while waiting for data (this allows working in tasks)
  • the debug ports are print only, they will never read the stream
  • simplify parsing of MQTT URC
  • allow getAPN to return also the PDP type, this allows proper PSD configuration, simplified code
  • fix readMQTT and better handle memory

@PaulZC PaulZC changed the base branch from main to release_candidate April 11, 2022 09:45
PaulZC
PaulZC reviewed Apr 11, 2022
View reviewed changes
PaulZC
PaulZC reviewed Apr 11, 2022
View reviewed changes
@PaulZC
Copy link
Collaborator

PaulZC commented Apr 11, 2022

Something I remembered last night... We need to add +UUMQTTC:, +CREG: and +CEREG: to this list:

SparkFun_u-blox_SARA-R5_Arduino_Library/src/SparkFun_u-blox_SARA-R5_Arduino_Library.cpp

Lines 6062 to 6071 in ce670f2

// These are the events we want to keep so they can be processed by poll / bufferedPoll
if ((strstr(event, "+UUSORD:") != NULL)
|| (strstr(event, "+UUSORF:") != NULL)
|| (strstr(event, "+UUSOLI:") != NULL)
|| (strstr(event, "+UUSOCL:") != NULL)
|| (strstr(event, "+UULOC:") != NULL)
|| (strstr(event, "+UUSIMSTAT:") != NULL)
|| (strstr(event, "+UUPSDA:") != NULL)
|| (strstr(event, "+UUPING:") != NULL)
|| (strstr(event, "+UUHTTPCR:") != NULL))

@PaulZC
Copy link
Collaborator

PaulZC commented Apr 11, 2022

Merging for testing...! Thank you Michael

@PaulZC PaulZC merged commit 714f761 into sparkfun:release_candidate Apr 11, 2022
@mazgch
Copy link
Contributor Author

mazgch commented Apr 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulZC PaulZC PaulZC left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mazgch @PaulZC